Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing field schemas #11987

Merged
merged 33 commits into from
Oct 11, 2023
Merged

Typing field schemas #11987

merged 33 commits into from
Oct 11, 2023

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Oct 6, 2023

Description

Proper typing field schemas in order to have type safety.

@adrinr adrinr force-pushed the labday/type_schema branch from 1dd377e to f38035a Compare October 10, 2023 16:54
@adrinr adrinr changed the base branch from develop to master October 10, 2023 16:54
@adrinr adrinr force-pushed the labday/type_schema branch from f38035a to a085589 Compare October 10, 2023 16:55
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #11987 (47da4cc) into master (6c3300a) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 85.71%.

❗ Current head 47da4cc differs from pull request most recent head f9d5855. Consider uploading reports for the commit f9d5855 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master   #11987   +/-   ##
=======================================
  Coverage   67.94%   67.95%           
=======================================
  Files         585      585           
  Lines       21755    21782   +27     
  Branches     4366     4379   +13     
=======================================
+ Hits        14781    14801   +20     
- Misses       6452     6458    +6     
- Partials      522      523    +1
Files Coverage Δ
...kages/server/src/api/controllers/table/external.ts 78.02% <100.00%> (+0.24%) ⬆️
...kages/server/src/api/controllers/table/internal.ts 79.78% <100.00%> (+0.83%) ⬆️
packages/server/src/constants/index.ts 100.00% <100.00%> (ø)
...ackages/server/src/db/linkedRows/LinkController.ts 95.08% <100.00%> (ø)
packages/server/src/db/linkedRows/linkUtils.ts 88.13% <100.00%> (-0.20%) ⬇️
packages/server/src/db/utils.ts 84.61% <100.00%> (+0.54%) ⬆️
packages/server/src/integrations/base/sqlTable.ts 73.33% <100.00%> (+0.22%) ⬆️
packages/server/src/integrations/oracle.ts 30.23% <ø> (+0.17%) ⬆️
packages/server/src/sdk/app/rows/utils.ts 76.62% <100.00%> (ø)
packages/server/src/sdk/app/tables/validation.ts 100.00% <100.00%> (ø)
... and 6 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adrinr adrinr requested a review from mike12345567 October 11, 2023 12:00
@adrinr adrinr marked this pull request as ready for review October 11, 2023 12:01
mike12345567
mike12345567 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me - what a massive improvement 🎉

@adrinr adrinr merged commit 7d31131 into master Oct 11, 2023
@adrinr adrinr deleted the labday/type_schema branch October 11, 2023 15:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mike12345567 mike12345567 mike12345567 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrinr @codecov-commenter @mike12345567